Skip to content

fix(drizzle): process bulk deletes sequentially to prevent silent data loss #16076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
razmenaia wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −12
Open

fix(drizzle): process bulk deletes sequentially to prevent silent data loss #16076

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions packages/payload/src/collections/operations/delete.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export const deleteOperation = async <

const errors: BulkOperationResult<TSlug, TSelect>['errors'] = []

const promises = docs.map(async (doc) => {
const processDoc = async (doc: (typeof docs)[number]) => {
let result

const { id } = doc
Expand Down Expand Up @@ -307,18 +307,17 @@ export const deleteOperation = async <
})
}
return null
})
}

// Process sequentially when using single transaction mode to avoid shared state issues
// Process in parallel when using one transaction for better performance
let awaitedDocs
if (req.payload.db.bulkOperationsSingleTransaction) {
awaitedDocs = []
for (const promise of promises) {
awaitedDocs.push(await promise)
}
} else {
awaitedDocs = await Promise.all(promises)
// Process documents sequentially to prevent concurrent deleteOne calls
// from interleaving queries on a shared transaction connection.
// Using .map(async ...) would eagerly start all callbacks, causing
// silent data loss even with for...of await (which only controls the
// order results are collected, not execution order).
// See: https://github.com/payloadcms/payload/issues/16075
const awaitedDocs = []
for (const doc of docs) {
awaitedDocs.push(await processDoc(doc))
}

// /////////////////////////////////////
Expand Down
Loading