fix(ui): doc drawer leave without saving modal#16140
Open
ACDR wants to merge 1 commit intopayloadcms:mainfrom
Open
fix(ui): doc drawer leave without saving modal#16140ACDR wants to merge 1 commit intopayloadcms:mainfrom
ACDR wants to merge 1 commit intopayloadcms:mainfrom
Conversation
DocumentDrawer also closes via the side "overlay" button and by pressing the Esc key - extend change from payloadcms#14324 to trigger the leave without saving modal when closing via keyboard Esc key or via the `close-drawer` button.
ACDR
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DocumentDraweralso closes via the side "overlay" button and by pressing the Esc key, these drawer exit methods currently do not trigger the "leave without saving" modal when the document has been modified, potentially resulting in data loss.This change extends #14324 to also trigger the modal when closing via keyboard Esc key or via the
close-drawerbutton.Related: #13947