Skip to content

fix run tests with summary output #16153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbaifigma wants to merge 1 commit into from
+12 −4
Closed

fix run tests with summary output #16153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions test/runTestsWithSummary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ function parseTestResults(output: string): { passed: number; total: number } {
if (typeof data.numPassedTests === 'number' && typeof data.numTotalTests === 'number') {
return {
passed: data.numPassedTests,
total: data.numTotalTests - (data.numTodoTests || 0),
total: data.numPassedTests + (data.numFailedTests || 0),
}
}
} catch (e) {
Expand Down Expand Up @@ -215,6 +215,11 @@ function runTestSuite(suiteName: string): SuiteResult {
result.failed = result.passed < result.total
}

// Flag 0/0 as failed — likely a beforeAll/init crash that skipped all tests
if (result.total === 0) {
result.failed = true
}

result.duration = Date.now() - startTime
return result
}
Expand Down Expand Up @@ -250,7 +255,9 @@ function main() {
results.push(result)

let statusIcon = '✅'
if (result.failed || result.passed < result.total) {
if (result.total === 0) {
statusIcon = '💥'
} else if (result.failed || result.passed < result.total) {
if (result.passed === 0) {
statusIcon = '❌'
} else {
Expand Down Expand Up @@ -304,8 +311,9 @@ function main() {
if (failedOrPartialSuites.length > 0) {
console.log('❌ Failed or partially failed suites:')
failedOrPartialSuites.forEach((r) => {
const icon = r.passed === 0 ? '❌' : '⚠️'
console.log(` ${icon} ${r.name} (${r.passed}/${r.total})`)
const icon = r.total === 0 ? '💥' : r.passed === 0 ? '❌' : '⚠️'
const suffix = r.total === 0 ? ' (init crashed — no tests ran)' : ''
console.log(` ${icon} ${r.name} (${r.passed}/${r.total})${suffix}`)
})
process.exit(1)
} else {
Expand Down
Loading