Skip to content

Refactor to fix warnings around frozen strings#14

Open
CloCkWeRX wants to merge 2 commits intopayrollhero:masterfrom
CloCkWeRX:html-safe
Open

Refactor to fix warnings around frozen strings#14
CloCkWeRX wants to merge 2 commits intopayrollhero:masterfrom
CloCkWeRX:html-safe

Conversation

@CloCkWeRX
Copy link

@CloCkWeRX CloCkWeRX commented Aug 3, 2025

When running tests, there were a number of warnings about modifying a frozen string.

Turns out, we can just rewrite this to be a ActiveRecord::SafeBuffer, which is safe to mutate.

@CloCkWeRX ➜ /workspaces/dynamic_form (html-safe) $ bundle exec rake test
Loaded suite /usr/local/rvm/gems/ruby-3.4.1/gems/rake-13.3.0/lib/rake/rake_test_loader
Started
Finished in 0.083011199 seconds.
----------------------------------------------------------------------------------------------------------------------------------------------------------------
31 tests, 44 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
----------------------------------------------------------------------------------------------------------------------------------------------------------------
373.44 tests/s, 530.05 assertions/s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants