Use separate ttl and ttw in LockManager#8
Open
mkhrystunov wants to merge 3 commits intopaysera:masterfrom
Open
Use separate ttl and ttw in LockManager#8mkhrystunov wants to merge 3 commits intopaysera:masterfrom
mkhrystunov wants to merge 3 commits intopaysera:masterfrom
Conversation
mSprunskas
requested changes
Aug 4, 2023
| public function createLock(string $resource): LockInterface | ||
| { | ||
| return $this->lockFactory->createLock($resource, null); | ||
| return $this->lockFactory->createLock($resource, $this->ttl); |
Contributor
There was a problem hiding this comment.
It's not clear why we even need to add ttl here. Why it was bad that it was null? Redis lock is not the same as resource lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Atm LockManager has
ttlparameter, but it's not being passed to theLockFactory::createLock. This creates a bit of confusion, because without checking the inside of the bundle it is not clear thatttlis not used fully.After the upgrade
ttlparameter is renamed tottw(Time to Wait) with same default value as it wasttlparameter is added which can be configured separately fromttwand will be passed toLockFactory::createLock