Allow read/write callbacks to respond with modbus exception codes#1
Open
grantramsay wants to merge 1 commit intopboettch:masterfrom
Open
Allow read/write callbacks to respond with modbus exception codes#1grantramsay wants to merge 1 commit intopboettch:masterfrom
grantramsay wants to merge 1 commit intopboettch:masterfrom
Conversation
grantramsay
commented
Sep 3, 2021
|
|
||
| send_response: | ||
| /* Check if a user read/write callback returned a negated error code within the | ||
| * range of modbus protocol exceptions, if so respond with that exception */ |
Author
There was a problem hiding this comment.
Alternatively could get the user to set errno in the callback, instead of returning the negated error number if you think that's better
Author
|
I found a workaround to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I'm using a protocol that runs on top of modbus.
It has requirements like: "If attempting to write a register to an invalid value, modbus Illegal-Data-Value exception must be returned".
This was not possible to do from the read/write callbacks, so I've made a minor change to allow it.
This is a great libmodbus fork btw