Week 5 Auth Exercise completed with all the routes#10
Open
marnel-mangrubang wants to merge 1 commit intopce-uw-jscript400:masterfrom
Open
Week 5 Auth Exercise completed with all the routes#10marnel-mangrubang wants to merge 1 commit intopce-uw-jscript400:masterfrom
marnel-mangrubang wants to merge 1 commit intopce-uw-jscript400:masterfrom
Conversation
bwreid
reviewed
Aug 11, 2019
Collaborator
bwreid
left a comment
bwreid
left a comment
There was a problem hiding this comment.
This is really excellent work! Nice job. :)
| next({ status: 400, message: 'Please enter a password!' }) | ||
| }else{ | ||
| //If password is provided validate for its length, error out if less then minimum of 8 characters | ||
| if(password.length < 8) next({ status: 400, message: 'Invalid password length. Please enter at least 8 characters.' }) |
Collaborator
There was a problem hiding this comment.
For all of these, I would add a return statement here.
|
|
||
|
|
||
|
|
||
| module.exports = { signupValidation, userAdmins, bookAdmins, reserver, returner } |
Collaborator
There was a problem hiding this comment.
These are all excellent. Well done using middleware. I would say some of the names could use some work, but that's one of the hardest things to do. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed all of the required routes and added middleware for authentication.