Open
Conversation
bwreid
reviewed
Aug 10, 2019
Collaborator
bwreid
left a comment
bwreid
left a comment
There was a problem hiding this comment.
Added some minor comments. Overall, everything looks great!
| var user = await User.findOne({username}); | ||
| if (user) | ||
| { | ||
| status = 400; |
Collaborator
There was a problem hiding this comment.
Since these are all the same, you could probably just define this at the top!
| } | ||
|
|
||
| const isValid = await bcrypt.compare(password, guest.password) | ||
| if (!isValid) throw new Error('Password is invalid'); |
Collaborator
There was a problem hiding this comment.
You'll want to use the same error message for both of the above errors. Otherwise, it's easier for someone to "guess" another user's username and is more insecure.
| error.status = 404 | ||
| return next(error) | ||
| } | ||
| if(!(user.admin)) |
Collaborator
There was a problem hiding this comment.
You shouldn't need the ()s here. Just !user.admin is fine.
| // You should only be able to reserve a book if a user is logged in | ||
| router.patch('/:id/reserve', async (req, res, next) => { | ||
| const { id } = req.params | ||
| var status; |
Collaborator
There was a problem hiding this comment.
You could use let instead!
|
|
||
| /// If able to return successfully, set reserved status to false and clear the memberId | ||
| book.reserved.status = false | ||
| book.reserved.memberId = "" |
Collaborator
There was a problem hiding this comment.
null might be a better value here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.