J.Sorge w5 Exercise - Complete#26
Open
Jiansorge wants to merge 1 commit intopce-uw-jscript400:masterfrom
Open
Conversation
bwreid
reviewed
Aug 17, 2019
Collaborator
bwreid
left a comment
bwreid
left a comment
There was a problem hiding this comment.
Overall this looks great. Just a couple comments.
|
|
||
| const payload = { id: user._id } | ||
| const options = { expiresIn: '1 day' } | ||
| const token = jwt.sign(payload, SECRET_KEY, options) |
Collaborator
There was a problem hiding this comment.
Because you're performing this operation multiple times, this is a great thing to put into a function.
| } | ||
|
|
||
| Object.assign(userToUpdate, admin) | ||
| await user.save() |
Collaborator
There was a problem hiding this comment.
This shouldn't work, as there's no user variable.
| try { | ||
| const token = req.headers.authorization.split('Bearer ')[1] | ||
| // A valid JWT token is not provided (status 401) | ||
| if (!token) { |
Collaborator
There was a problem hiding this comment.
You don't want to just check whether or not there is a token, you want to check whether or not the token is valid. In this case, you should use payload from below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.