exercise-express -- Griffiths#19
Open
crgriffiths wants to merge 3 commits intopce-uw-jscript400:masterfrom
Open
exercise-express -- Griffiths#19crgriffiths wants to merge 3 commits intopce-uw-jscript400:masterfrom
crgriffiths wants to merge 3 commits intopce-uw-jscript400:masterfrom
Conversation
bwreid
reviewed
Jul 15, 2019
Contributor
bwreid
left a comment
bwreid
left a comment
There was a problem hiding this comment.
Great job! There are a few things that are different than the instructions, but overall everything seems to work well.
|
|
||
| if (!fruit) { | ||
| const message = `Could not find fruit with ID of ${id}` | ||
| next({ status: 404, message }) |
Contributor
There was a problem hiding this comment.
You should return here, to avoid the error of:
Cannot set headers after they are sent to the client
| } | ||
|
|
||
| const fruit = fruits.splice(fruitIdx,1); | ||
| res.json(fruit) |
Contributor
There was a problem hiding this comment.
This will return an array as opposed to an object, which is what the instructions ask for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.