Open
Conversation
bwreid
reviewed
Jul 26, 2019
| * **Question:** Why do we get a response when we go to `/` but not `/notfound`? | ||
|
|
||
| * **Your Answer:** | ||
| * **Your Answer:** There's a get request response for only the index file. We have not defined the /notfound route anywhere in the app. |
Contributor
There was a problem hiding this comment.
Small note, but it's not necessarily the index file, but rather the index route.
| * **Question:** What is `req.params`? What else will you need to change if you change the path to `/my/name/is/:username`? | ||
|
|
||
| * **Your Answer:** | ||
| * **Your Answer:** these are the query parameters used in the queries url string. You will need to change the response to utilize req.params. You can change the ':username' part of the parth. |
Contributor
There was a problem hiding this comment.
In this case, we'd actually talk about this as "route parameters." "Query parameters" are what comes after the route ends (i.e. after the ?).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.