Griffiths -- W5 Lesson Notes#14
Open
crgriffiths wants to merge 2 commits intopce-uw-jscript400:masterfrom
Open
Griffiths -- W5 Lesson Notes#14crgriffiths wants to merge 2 commits intopce-uw-jscript400:masterfrom
crgriffiths wants to merge 2 commits intopce-uw-jscript400:masterfrom
Conversation
MadEste
reviewed
Aug 7, 2019
|
|
||
| * **Your Answer:** | ||
| * **Your Answer:** You would pass credentials to the server, the server would authenticate the request by validating the user/password combination. If successful, the server would return an auth token that the user would use with any additional requests so the server knows that the request should be accepted for any routes requiring you to be logged in. | ||
|
|
MadEste
reviewed
Aug 7, 2019
|
|
||
| * **Your Answer:** | ||
| * **Your Answer:** It is a more logical expression of the action we are doing, not just the data said route would return or what that data represents. | ||
|
|
MadEste
reviewed
Aug 7, 2019
|
|
||
| * **Your Answer:** | ||
| * **Your Answer:** Because the action is actually validated two fields, not just one. It is entirely possible the user entered the correct password, but entered their username incorrectly. The error message should point out that there was an issue with the combination of credentials used. | ||
|
|
There was a problem hiding this comment.
Yes, specifically to make it more difficult for hackers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.