lesson notes and mini assignment#26
Open
janauhrich wants to merge 2 commits intopce-uw-jscript400:masterfrom
Open
lesson notes and mini assignment#26janauhrich wants to merge 2 commits intopce-uw-jscript400:masterfrom
janauhrich wants to merge 2 commits intopce-uw-jscript400:masterfrom
Conversation
added 2 commits
July 23, 2019 20:54
bwreid
reviewed
Aug 21, 2019
| * **Question:** Why are we making our route `POST /api/signup` as opposed to `POST /api/users`? | ||
|
|
||
| * **Your Answer:** | ||
| * **Your Answer:** it's more official - gives the user an idea of the action they are taking. |
Collaborator
There was a problem hiding this comment.
Yes, but also the process of signing up is also slightly different than just creating a user. There could be an instance where you have both, for example.
- One for users to sign up
- One for admin to create new users
| * **Question:** Which of our current routes will require us to use the `jsonwebtoken` library? (i.e. When will we be creating or decoding JWTs?) | ||
|
|
||
| * **Your Answer:** | ||
| * **Your Answer:** the login route |
Collaborator
There was a problem hiding this comment.
And signup, if we want to return a token there too!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.