Skip to content

Modifications#53

Closed
wmbutler wants to merge 13 commits intopdffillerjs:masterfrom
wmbutler:modifications
Closed

Modifications#53
wmbutler wants to merge 13 commits intopdffillerjs:masterfrom
wmbutler:modifications

Conversation

@wmbutler
Copy link

Here is the correct pull request. Sorry, I made some readme changes on my version that would have been wrong on yours.

@whitef0x0
Copy link
Contributor

whitef0x0 commented Feb 27, 2017

@wmbutler I think it would be best to add this functionality as an opt-in option instead of having it on by default, to prevent breaking changes.

@wmbutler
Copy link
Author

I saw your comment after this. So, maybe a flag called --keep?

@whitef0x0
Copy link
Contributor

@wmbutler might be better to add an options object when you require the library.

@wmbutler
Copy link
Author

I'm not sure I follow.

@whitef0x0
Copy link
Contributor

@whitef0x0
Copy link
Contributor

@wmbutler I just added an option and added tests in this new PR #54 based off your code.

@wmbutler
Copy link
Author

Closing this in response to @whitef0x0 pull request.

@wmbutler wmbutler closed this Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants