Skip to content

Conversation

@williamdes
Copy link

While running phpunit tests I got some concerning warnings, I fixed them

1) Net_URL2Test::testNormalize
* Data set #0 provided by Net_URL2Test::provideEquivalentUrlLists has more arguments (2) than the test method accepts (1)

* Data set #1 provided by Net_URL2Test::provideEquivalentUrlLists has more arguments (2) than the test method accepts (1)

* Data set #2 provided by Net_URL2Test::provideEquivalentUrlLists has more arguments (2) than the test method accepts (1)

* Data set #3 provided by Net_URL2Test::provideEquivalentUrlLists has more arguments (2) than the test method accepts (1)

* Data set #4 provided by Net_URL2Test::provideEquivalentUrlLists has more arguments (4) than the test method accepts (1)

* Data set #5 provided by Net_URL2Test::provideEquivalentUrlLists has more arguments (2) than the test method accepts (1)

* Data set #6 provided by Net_URL2Test::provideEquivalentUrlLists has more arguments (2) than the test method accepts (1)

/mnt/Dev/@debian/@qa/php-net-url2/Net_URL2-2.2.3/tests/Net/URL2Test.php:864

2) Net_URL2Test::testConstructSelf
* Data set #0 provided by Net_URL2Test::provideEquivalentUrlLists has more arguments (2) than the test method accepts (0)

* Data set #1 provided by Net_URL2Test::provideEquivalentUrlLists has more arguments (2) than the test method accepts (0)

* Data set #2 provided by Net_URL2Test::provideEquivalentUrlLists has more arguments (2) than the test method accepts (0)

* Data set #3 provided by Net_URL2Test::provideEquivalentUrlLists has more arguments (2) than the test method accepts (0)

* Data set #4 provided by Net_URL2Test::provideEquivalentUrlLists has more arguments (4) than the test method accepts (0)

* Data set #5 provided by Net_URL2Test::provideEquivalentUrlLists has more arguments (2) than the test method accepts (0)

* Data set #6 provided by Net_URL2Test::provideEquivalentUrlLists has more arguments (2) than the test method accepts (0)

/mnt/Dev/@debian/@qa/php-net-url2/Net_URL2-2.2.3/tests/Net/URL2Test.php:953

Origin: vendor
Forwarded: pear#22
@williamdes williamdes force-pushed the williamdes/phpunit-12 branch from 871f065 to bb78ba8 Compare September 8, 2025 15:23
@williamdes
Copy link
Author

I also did add some bumps to match what is tested by CIs: 8f6978d

I am not sure that old PHP projects need updates

@williamdes
Copy link
Author

Hi @ktomk
What do you think of my PR ?

@reedy reedy mentioned this pull request Jan 6, 2026
},
"require": {
"php": ">=5.1.4"
"php": ">=5.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nicer to have better policies about this...

PHP 7.4 is EOL for over 3 years, 5.3 over 11...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants