add dependency on pear-core-minimal

[gggeek]

I am not privy how PEAR is supposed to work when installed via Composer - whether packages such as this should depend on pear-core or pear-core-minimal, but still atm the OLE package does not work when installed stand-alone via composer

[gggeek]

ps: i just noticed that pear-core-minimal is already in dev deps, but with a higher min version. I can amend this PR for that...

[sanmai]

It will force everyone to install pear/pear-core-minimal even if they have pear/pear installed.

[gggeek]

@sanmai you are right.

This is why I think that, before merging this, some work needs to be done within the pear core packages, so that only one of either pear-core-minimal or pear-pear gets installed.

I have created an issue for that at pear/pear-core#142, but so far there has not been a lot of feedback...

[ashnazg]

I think you'll need to remove the minimal entry in the dev section.

[gggeek]

Will do

[ashnazg]

I've made this update separately.

[ashnazg]

Are we sure minimal causing a hard requirement on core? The composer.json from pear-core has been listing a replace pear-core-minimal in it since 58bde0e in 2017. I've just added exception to that list in core today too.

[gggeek]

Will test different scenarios, to determine what works best: whether specifying a minimum version of pear-core-minimal of 1.10.0 or 1.10.16 makes a difference, or whether that does not make any difference, but we still get double-installs when having pear/pear versions before 1.10.16)

• with nothing else required(as in "required by the main project's composer.json")
• with pear/pear required (>= 1.10.0)
• with pear/pear required (>= 1.10.16)
• with pear/pear_exception required
• with both pear/pear and pear/pear_exception required

[gggeek]

@ashnazg I finally managed to do some testing.

Sadly, the fix in pear/pear which went into rel. 1.0.16 has a typo, so atm if one is to depend on both pear/ole and pear/pear, Composer will still install 2 copies of the pear Exception class.

I sent in a PR to fix that: pear/pear-core#153

Otoh, adding a dependency on both pear/pear and pear/pear-core-minimal does not result in pear-core-minimal being installed at all, as you have correctly stated above.

I thus propose the following plan:

1. merge PR 153 and release pear/pear 1.0.17
2. merge this PR and release pear/ole 1.0.1

[ashnazg]

I've applied your update in the context of including my review changes, and just released v1.0.1 for OLE after getting PEAR v1.10.17 out too. Closing this as handled... comment back if issue still seems to remain.