Various performance improvements#2046
Conversation
|
Hello, Thank you for the PR! I was doing tests and all seems good except the AndroidViewFilterRender and that you need move ObservableWebView to common module because you can't use it from encoder module. Also, I'm not sure if the color change in the VideoEncoder is secure for old devices (encoders and players that will reproduce the video) and should be disabled by default, but Anyway, I think that the code should check that if the version is older than Android N and the patch never should be done because you can't change it in the MediaFormat anyway: What do you think about it? |
|
Yes, I completely agree to have the color profile set to false by default, I think the best is to have a flag and turn it on by the user? Yes, if the ObservableWebView should be in a different module then sure. I am wondering if you can do it? thanks |
|
Hello, Ok, I will do it. |
|
Thanks! Once this is in I will try it out in my app, and let you know. Thanks again!!! |
These are the performance improvements I mentioned in the following issues
#2044
#2043
#2040
For
AndroidViewFilterRenderI also add arenderflag, so if this flag is false then this view will not be rendered at all, so if we have more than one view filters we can turn it on or off easily.Thanks!