support semi-colon delimited names

[missinglink]

replaces #581

note: commits need to be squashed and correctly prefixed (with feat:) before merging.

This PR adds support for semi-colon delimited names in OSM.
see: https://wiki.openstreetmap.org/wiki/Talk:Semi-colon_value_separator

Compared to #581 I added:

• Cleaning parsed values (trimming whitespace and filtering empty strings, ie. '' or foo;;bar)
• Support for semi-colon delimited names in lang fields (ie. name:en) as well as those in NAME_SCHEMA.
• Moved parseSemicolonDelimitedValues() function to it's own module as it's used in the address_extractor too.
• Removed this weird _primary key from NAME_SCHEMA which probably seemed like a good idea at the time but is unnecessarily confusing.
• Updated the code which hunts for a default name when one wasn't available, also made this semi-colon aware.
• Code modernisation & cleanup - variables were confusingly named, code was dated (using var instead of const etc.)

closes #581

[missinglink]

There are some confusing aspects of this code, I probably wrote a bunch of this so I'm guilty, but revisiting it after so long I felt it wasn't super intuitive, I made some attempts to improve it.

Some things which are still a bit clunky are:

• The way doc.setName() and doc.setNameAlias() work is kinda clunky, it requires the caller to know if that specific name property was previously set before selecting a method to use. It would be much easier if we could just call a single function and have pelias/model figure it out.
• We loop over the OSM tags once to save CPU, this seems ok, however we are looking for the name key to set as a primary value (ie. first in the name values list), so there is a conditional IF inside the loop to handle that value differently.

[missinglink]

This was kinda weird and overly fancy, I removed it.

[orangejulius]

Over the years we've learned many things you can do with Javascript, but shouldn't :P

[missinglink]

cc/ @SiarheiFedartsou, @orangejulius

[SiarheiFedartsou]

👍🏻

[missinglink]

diff --git a/util/parseSemicolonDelimitedValues.js b/util/parseSemicolonDelimitedValues.js
index 08e21ac..39c123b 100644
--- a/util/parseSemicolonDelimitedValues.js
+++ b/util/parseSemicolonDelimitedValues.js
@@ -5,8 +5,8 @@ const _ = require('lodash');
 function parseSemicolonDelimitedValues(value) {
   return (_.isString(value) ? value : '')
     .split(';')
-    .map(Function.prototype.call, String.prototype.trim)
-    .filter(Boolean);
+    .map(v => v.trim())
+    .filter(v => v.length);
 }

 module.exports = parseSemicolonDelimitedValues;
\ No newline at end of file

[orangejulius]

Much cleaner after these changes. I had one idea for a further improvement but it's not mandatory at all.

[orangejulius]

Over the years we've learned many things you can do with Javascript, but shouldn't :P

[orangejulius]

Ah nice this is much cleaner.

[orangejulius]

More fanciness :P

So just to confirm, this is because you can't use || when assigning to const, yeah?

Might actually be a use case for let in that case, as it's much more clear what the intention is, plus each of these function calls has to always be evaluated, whereas chained || will have an early return as soon as there's a truthy value, right?