Merged
Conversation
Member
|
Yeah I'm fine to remove this. The original reason was in order to be able to test different versions of the JDK in a split-test production environment. I think that can also be achieved through custom Docker files. |
For quite some time we have configured a specific version of the JDK in our CI. As far as I understand it, modern versions of Elasticsearch use a bundled version of the JDK so this configuration may no longer be relevant. On a practical/security note: it also looks like [the scripts](https://github.com/michaelklishin/jdk_switcher) used to switch JDK versions are over 4 years old, and just calling a bash script from a 3rd party repository is a bit scary. I don't see any changes due to the removal of this option, is it possible we don't need it anymore?
orangejulius
force-pushed
the
remove-jdk-configuration
branch
from
7898072 to
45bec95
Compare
Member
Author
|
I found this old PR and updated it. Seems like it's still a good thing to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For quite some time we have configured a specific version of the JDK in our CI.
As far as I understand it, modern versions of Elasticsearch use a bundled version of the JDK so this configuration may no longer be relevant.
On a practical/security note: it also looks like the scripts used to switch JDK versions are over 4 years old, and just calling a bash script from a 3rd party repository is a bit scary.
I don't see any changes due to the removal of this option, is it possible we don't need it anymore? @missinglink what do you think?