Open
Conversation
main/mains.py
Outdated
| 'Hogwarts', 'Mordor', 'Orange', 'Turquoise', | ||
| 'Peach', 'Cyan'] | ||
|
|
||
| for i in range(0, len(office_names)): |
There was a problem hiding this comment.
Code Quality: Nitpick
This could have been written as.
for office in office_name:
self.offices.append(Office(office))Much shorter, less confusing, no need for the indexes.
| 'Hogwarts', 'Mordor', 'Orange', 'Turquoise', | ||
| 'Peach', 'Cyan'] | ||
|
|
||
| for office in range(0, len(office_names)): |
There was a problem hiding this comment.
Code Quality: Nitpick
We could also write this as:
for office_name in office_names:
self.offices.append(Office(office_name))Without the range operation. It is much easier to read IMO and gets rid of the indexes.
The same thing was done below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.