Skip to content

Conversation

@khoroshevskyi
Copy link
Member

@khoroshevskyi khoroshevskyi commented Mar 26, 2025

Changes:

  • Added new schema (records, versions, tags)

TODO:

sanghoonio and others added 30 commits December 11, 2024 16:18
…sample table to filter out ph_id, and set default schema dropdown in new pep modal to databio/pep-2.1.0
# Conflicts:
#	pephub/_version.py
bring in task def changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the release to 0.15.0 and introduces new schema functionality including records, versions, and tags. Key changes include a new key-value input component, extensive updates to the schemas API with modified payloads and endpoints for schema versions, and adjustments to various namespace and project routes across both the API and UI.

Reviewed Changes

Copilot reviewed 58 out of 62 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
web/src/components/forms/components/key-value-input.tsx New component enabling tag-based key/value input.
web/src/api/schemas.ts Updates to schema types and endpoints (including schema versioning) with updated query parameters and payload structure.
pephub/helpers.py Addition of a new function to download JSON content.
pephub/routers/api/v1/namespace.py, pephub/routers/models.py, web/src/api/namespace.ts Adjustments to namespace information routes and modeling, aligning with new schema functionality.
pephub/dependencies.py, pephub/routers/api/v1/project.py, pephub/main.py Various routing, dependency, and version updates across the codebase.
web/src/components/forms/components/schemas-databio-dropdown.tsx, combined-error-message.tsx, namespace-grid.tsx, namespace-long-row.tsx Modifications to utilize the new schema naming conventions and improve UI consistency.
.github/workflows/black.yml Workflow update to newer action versions.
pephub/_version.py Version bump to 0.15.0_dev0.
Files not reviewed (4)
  • deployment/task_defs/dev.json: Language not supported
  • deployment/task_defs/primary.json: Language not supported
  • launch_docker.sh: Language not supported
  • requirements/requirements-all.txt: Language not supported

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 26, 2025

Deploying pephub-ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: 586555c
Status: ✅  Deploy successful!
Preview URL: https://3aa1e995.pephub.pages.dev
Branch Preview URL: https://dev.pephub.pages.dev

View logs

pepdbagent>=0.11.1
# pepdbagent @ git+https://github.com/pepkit/pepdbagent.git@schams2.0#egg=pepdbagent
#pepdbagent>=0.11.1
pepdbagent @ git+https://github.com/pepkit/pepdbagent.git@dev#egg=pepdbagent

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to change this.

Copy link

@donaldcampbelljr donaldcampbelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python looks good. Did not review .ts files.

Address sample table issues related to copying and pasting ph_id col
Copy link
Member

@nleroy917 nleroy917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works.. I approve. I didnt have time to go through his with a fine-toothed comb, however since there were so many changes

@@ -1 +1 @@
__version__ = "0.14.4"
__version__ = "0.15.0_dev0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are merging to master, should we change this?

Comment on lines +192 to +200
formData.append('schema_name', schemaName || '');
formData.append('description', description || '');
formData.append('private', isPrivate.toString());
formData.append('contributors', contributors || '');
formData.append('maintainers', maintainers || '');
formData.append('tags', tags ? JSON.stringify(tags) : '{}');
formData.append('version', version || '');
formData.append('release_notes', releaseNotes || '');
formData.append('lifecycle_stage', lifecycleStage || '');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that i started this trend, but is it ok if we append empty strings?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like prettier needs run on this

@khoroshevskyi khoroshevskyi merged commit 44a7b71 into master Mar 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants