fix Fingerprint fi overflow cause index out of range panic#30
fix Fingerprint fi overflow cause index out of range panic#30martianzhang wants to merge 5 commits intopercona:masterfrom
Conversation
sql: insert into tb values (1)
Fingerprint(sql) got panic: index out of range
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
=========================================
- Coverage 63.91% 63.82% -0.1%
=========================================
Files 8 8
Lines 1416 1418 +2
=========================================
Hits 905 905
- Misses 400 401 +1
- Partials 111 112 +1
Continue to review full report at Codecov.
|
Merge new update
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 67.02% 67.07% +0.04%
==========================================
Files 7 7
Lines 1389 1391 +2
==========================================
+ Hits 931 933 +2
Misses 348 348
Partials 110 110
Continue to review full report at Codecov.
|
|
Thanks for contributing @martianzhang! Let us check this and get back to you soon |
percona-csalguero
left a comment
There was a problem hiding this comment.
Without the code change, the tests are passing anyways.
I don't think we need to merge this.
In order to accept this change, I would like to see a failing case.
|
@percona-csalguero I update the test case, no space between |
Uh oh!
There was an error while loading. Please reload this page.