-
Notifications
You must be signed in to change notification settings - Fork 451
Note use of direct conneciton with --split-cluser
#1134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I found that when using `--split-cluster` you should also use direct connections, otherwise it just only connects to the same replica and reports its metrics as if all the replicas have exactly the same metric values.
|
|
|
@dobesv could you sign CLA? Thank you. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1134 +/- ##
==========================================
- Coverage 70.88% 64.82% -6.07%
==========================================
Files 28 29 +1
Lines 3569 2428 -1141
==========================================
- Hits 2530 1574 -956
+ Misses 904 713 -191
- Partials 135 141 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|

I found that when using
--split-clusteryou should also use direct connections, otherwise it just only connects to the same replica and reports its metrics as if all the replicas have exactly the same metric values.