Skip to content

CDP #374 - Footer buttons#418

Open
dleadbetter wants to merge 1 commit intodevelopfrom
feature/cdp374_footer_buttons
Open

CDP #374 - Footer buttons#418
dleadbetter wants to merge 1 commit intodevelopfrom
feature/cdp374_footer_buttons

Conversation

@dleadbetter
Copy link
Contributor

@dleadbetter dleadbetter commented Jan 16, 2026

This pull request fixes the issues with the LinkButton components in the footer presented in #374.

Disclaimer: This seems to have broken some of the places where this component is used as a link without padding and with underline text decoration. I would argue that the purpose of this component is to format a <a> tag as a button, so perhaps we need a separate component for when we want to render a more traditional link?

Screenshot 2026-01-16 at 6 49 34 AM Screenshot 2026-01-16 at 6 50 07 AM

@dleadbetter dleadbetter requested a review from ajolipa January 16, 2026 11:52
@netlify
Copy link

netlify bot commented Jan 16, 2026

Deploy Preview for pss-scavenger-hunt ready!

Name Link
🔨 Latest commit d16d958
🔍 Latest deploy log https://app.netlify.com/projects/pss-scavenger-hunt/deploys/696a266ba66e6e00088e6599
😎 Deploy Preview https://deploy-preview-418--pss-scavenger-hunt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 16, 2026

Deploy Preview for gbof-c19nyc-staging ready!

Name Link
🔨 Latest commit d16d958
🔍 Latest deploy log https://app.netlify.com/projects/gbof-c19nyc-staging/deploys/696a266b20ed0d00082adf26
😎 Deploy Preview https://deploy-preview-418--gbof-c19nyc-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 16, 2026

Deploy Preview for padp-staging ready!

Name Link
🔨 Latest commit d16d958
🔍 Latest deploy log https://app.netlify.com/projects/padp-staging/deploys/696a266b9a91320008546d55
😎 Deploy Preview https://deploy-preview-418--padp-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dleadbetter dleadbetter added the next release Issues in the next release label Jan 16, 2026
@netlify
Copy link

netlify bot commented Jan 16, 2026

Deploy Preview for juel-staging ready!

Name Link
🔨 Latest commit d16d958
🔍 Latest deploy log https://app.netlify.com/projects/juel-staging/deploys/696a266bc1439500080c380f
😎 Deploy Preview https://deploy-preview-418--juel-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 16, 2026

Deploy Preview for universities-studying-slavery-staging ready!

Name Link
🔨 Latest commit d16d958
🔍 Latest deploy log https://app.netlify.com/projects/universities-studying-slavery-staging/deploys/696a266b72f60600088cc6c5
😎 Deploy Preview https://deploy-preview-418--universities-studying-slavery-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 16, 2026

Deploy Preview for libertos ready!

Name Link
🔨 Latest commit d16d958
🔍 Latest deploy log https://app.netlify.com/projects/libertos/deploys/696a266be6b130000858168a
😎 Deploy Preview https://deploy-preview-418--libertos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@camdendotlol camdendotlol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Going by https://github.com/search?q=repo%3Aperformant-software%2Fcore-data-places%20linkbutton&type=code this component doesn't seem to be used in a lot of places so the issue in the disclaimer should be easy to take care of.

@camdendotlol camdendotlol removed the request for review from ajolipa January 20, 2026 19:39
@dleadbetter
Copy link
Contributor Author

@ajolipa - Do you have any thoughts on this before I merge it? I'm not entirely sure what impact (if any) it will have on the JUEL sites.

@dleadbetter
Copy link
Contributor Author

@ajolipa - Bumping this again to see if you know how this will impact the JUEL sites?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

next release Issues in the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants