Adding published flag and post categories #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for padp-staging processing.
|
✅ Deploy Preview for pss-scavenger-hunt ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for gbof-c19nyc-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for juel-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for universities-studying-slavery-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for libertos ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This was
linked to
issues
Jan 22, 2026
Open
✅ Deploy Preview for juel-ancestry ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for juel-life ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
❌ Deploy Preview for registro-project failed. Why did it fail? →
|
dleadbetter
reviewed
Jan 28, 2026
| } | ||
| </div> | ||
| <div className='flex flex-col italic text-lg divide-y divide-secondary text-[#222222]'> | ||
| { loading && <p className='not-italic text-base'>{t('loading') || 'Loading'}...</p>} |
Contributor
There was a problem hiding this comment.
If the loading key is in the i18n.json file, I don't think we need the hard-coded "Loading" label here.
Contributor
Author
There was a problem hiding this comment.
Oh yeah good catch, this was an impatient step to test it out quickly which I never went back and fixed. Thanks!
| className='hover:underline hover:font-semibold py-4 font-header' | ||
| href={getRelativeLocaleUrl(lang, `posts/${post._sys.filename}`)} | ||
| key={post._sys.filename} | ||
| href={getRelativeLocaleUrl(lang, `posts/${post?._sys?.filename}`)} |
Contributor
There was a problem hiding this comment.
Interesting. Will the posts array ever contain null/undefined values?
| )) } | ||
| </div> | ||
| { cursor && ( | ||
| { showMore && !loading && ( |
Contributor
There was a problem hiding this comment.
Do we also need to check for cursor here?
| label: 'Localize Pages', | ||
| type: 'boolean' | ||
| }, { | ||
| name: 'posts_config', |
Contributor
There was a problem hiding this comment.
Let's document these changes in the README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
publishflag to thepostsmodel to optionally use a draft/published workflow where posts aren't shown on the frontend until they're markedpublish;categorieslist to the posts schema which is populated from a list of values set in theconfig.jsonfile; when present it will add a dropdown menu to the posts page where viewers can select a category to filter by.Notes
pathsas well because why not, but it looks like paths hasn't yet been updated to the progressing loading thing, so it would be a few more steps to add the filtering and category stuff there.ListBoxcomponent for the dropdown since as best I could tell we don't have a simple list select component built out in ourreact-componentslibrary, but it's definitely possible that I just missed something. In the future if we do add such a component to the library, this should probably be updated to use it.