Skip to content

Conversation

@ajolipa
Copy link
Contributor

@ajolipa ajolipa commented Jan 27, 2026

In this PR

Resolves #438 by adding range to the set of allowed type values for items in the search.facets field in the config. This is necessary because in some data models (e.g. JUEL) we may have numeric fields on models that aren't the dates of associated events, which is currently the only thing we display as a range facet by default I believe.

Note that upon testing it seems that a non-numerical field with range as the specified type will simply not render, and will not crash the page or cause any errors, so the danger is low in giving users this power.

@ajolipa ajolipa requested a review from dleadbetter January 27, 2026 06:37
@netlify
Copy link

netlify bot commented Jan 27, 2026

Deploy Preview for pss-scavenger-hunt ready!

Name Link
🔨 Latest commit dc3fbbc
🔍 Latest deploy log https://app.netlify.com/projects/pss-scavenger-hunt/deploys/69785d3f18365700080901e6
😎 Deploy Preview https://deploy-preview-460--pss-scavenger-hunt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 27, 2026

Deploy Preview for gbof-c19nyc-staging ready!

Name Link
🔨 Latest commit dc3fbbc
🔍 Latest deploy log https://app.netlify.com/projects/gbof-c19nyc-staging/deploys/69785d3f2674f100077ebd08
😎 Deploy Preview https://deploy-preview-460--gbof-c19nyc-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 27, 2026

Deploy Preview for padp-staging ready!

Name Link
🔨 Latest commit dc3fbbc
🔍 Latest deploy log https://app.netlify.com/projects/padp-staging/deploys/69785d3f6160330008bfe540
😎 Deploy Preview https://deploy-preview-460--padp-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 27, 2026

Deploy Preview for juel-staging ready!

Name Link
🔨 Latest commit dc3fbbc
🔍 Latest deploy log https://app.netlify.com/projects/juel-staging/deploys/69785d3f92fe3100080dda73
😎 Deploy Preview https://deploy-preview-460--juel-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 27, 2026

Deploy Preview for juel-life ready!

Name Link
🔨 Latest commit dc3fbbc
🔍 Latest deploy log https://app.netlify.com/projects/juel-life/deploys/69785d3f54fc7e0008016e62
😎 Deploy Preview https://deploy-preview-460--juel-life.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 27, 2026

Deploy Preview for universities-studying-slavery-staging ready!

Name Link
🔨 Latest commit dc3fbbc
🔍 Latest deploy log https://app.netlify.com/projects/universities-studying-slavery-staging/deploys/69785d3f6607f70008b5127a
😎 Deploy Preview https://deploy-preview-460--universities-studying-slavery-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 27, 2026

Deploy Preview for libertos ready!

Name Link
🔨 Latest commit dc3fbbc
🔍 Latest deploy log https://app.netlify.com/projects/libertos/deploys/69785d3f199169000838b41f
😎 Deploy Preview https://deploy-preview-460--libertos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 27, 2026

Deploy Preview for registro-project failed. Why did it fail? →

Name Link
🔨 Latest commit dc3fbbc
🔍 Latest deploy log https://app.netlify.com/projects/registro-project/deploys/69785d3f3d44fa00086b2d5b

@netlify
Copy link

netlify bot commented Jan 27, 2026

Deploy Preview for juel-ancestry ready!

Name Link
🔨 Latest commit dc3fbbc
🔍 Latest deploy log https://app.netlify.com/projects/juel-ancestry/deploys/69785d3f22fa5c000859df89
😎 Deploy Preview https://deploy-preview-460--juel-ancestry.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dleadbetter dleadbetter added the next release Issues in the next release label Jan 28, 2026
Copy link
Contributor

@dleadbetter dleadbetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should happen automatically for any numeric system fields or user-defined fields with type "Number". If it's not happening automatically with the correct configuration, then it's a bug we should fix. Users will likely never want to see a huge list of numbers.

@ajolipa
Copy link
Contributor Author

ajolipa commented Jan 28, 2026

I think this should happen automatically for any numeric system fields or user-defined fields with type "Number". If it's not happening automatically with the correct configuration, then it's a bug we should fix. Users will likely never want to see a huge list of numbers.

It is definitely not happening automatically -- see e.g. https://juel-staging.netlify.app/en/search/people . Looks like the issue might be that the context provider is looking only for fields of type int64[], but the fields in question in this case are type int64 in Typesense:
image

Seems like ideally we'd fix it in react-components as you say; the downside to that is just time, so I'll leave that up to you. ^_^;

@ajolipa ajolipa requested a review from dleadbetter January 28, 2026 16:48
@dleadbetter
Copy link
Contributor

How much longer do you think it would take to fix in react-components? I think it would be worth it so that users do not have to manually set the type on the facet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

next release Issues in the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow range type for facets

3 participants