Merged
Conversation
This was referenced Apr 23, 2025
k-rister
requested changes
Apr 23, 2025
Contributor
k-rister
left a comment
k-rister
left a comment
There was a problem hiding this comment.
This looks great but this script should be in in the bin/ directory instead of python/toolbox/ since it's a generic utility that anyone should be able to use.
Contributor
Author
Ok, I missed that part :) |
Contributor
|
The individual language directories ( |
This utility imports the system_topology module to convert a cpu list to range.
rafaelfolco
force-pushed
the
get-cpu-range
branch
from
09c3ef6 to
e48bd12
Compare
k-rister
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the cpu_formatted_list method from system_topology class to convert list to range.