Skip to content

[Snyk] Security upgrade react-scripts from 3.4.0 to 5.0.0 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Security upgrade react-scripts from 3.4.0 to 5.0.0 #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion demo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"react": "^16.10.1",
"react-dom": "^16.10.1",
"react-error-boundary": "^1.2.5",
"react-scripts": "3.4.0"
"react-scripts": "5.0.0"
Copy link

@amazon-q-developer amazon-q-developer bot Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛑 Breaking Change Risk: This upgrade from react-scripts 3.4.0 to 5.0.0 spans multiple major versions and introduces significant breaking changes. React Scripts 5.0.0 requires React 17+ and Node.js 14+, but this project is still using React 16.10.1. This version mismatch will likely cause build failures and runtime issues1.

Footnotes

  1. CWE-1104: Use of Unmaintained Third Party Components - https://cwe.mitre.org/data/definitions/1104.html ↩

Copy link

@amazon-q-developer amazon-q-developer bot Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current React version (16.10.1) is incompatible with react-scripts 5.0.0, which requires React 17+. This dependency mismatch will cause build failures. Consider upgrading React and React DOM to version 17 or 18 alongside this react-scripts upgrade to ensure compatibility.

Copy link

@amazon-q-developer amazon-q-developer bot Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Material-UI v4 components may have compatibility issues with newer React versions. If you upgrade React to support react-scripts 5.0.0, consider also upgrading to Material-UI v5 (now @mui/material) to avoid potential deprecation warnings and ensure long-term support.

Copy link

@amazon-q-developer amazon-q-developer bot Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React Scripts 5.0.0 includes webpack 5 and may require Node.js 14+ to run properly. Verify that your development and deployment environments meet these minimum requirements before merging this upgrade.

Copy link

@amazon-q-developer amazon-q-developer bot Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The react-error-boundary version (1.2.5) is quite outdated and may not be compatible with newer React versions. Consider upgrading to react-error-boundary v4+ which provides better TypeScript support and React 18 compatibility.

},
"scripts": {
"start": "react-scripts start",
Expand Down