- 
                Notifications
    You must be signed in to change notification settings 
- Fork 3
          Configure ada_description for Articulable Fork
          #52
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Draft
      
      
            jjaime2
  wants to merge
  29
  commits into
  main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
jjaime2/articulable_fork_description
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Draft
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            29 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      d0544a6
              
                Update forque_assembly_joint macro to allow fixed, revolute, and cont…
              
              
                jjaime2 7847a68
              
                Add Articulable Fork XACRO and STL
              
              
                jjaime2 f72a2f8
              
                Rename AFMotor2_to_AFMotorFixture1 to AFMotor2_to_AFMotor1
              
              
                jjaime2 c102e12
              
                Format forque.xacro using xmllint
              
              
                jjaime2 9d435d9
              
                Rename Articulable Fork links and joints
              
              
                jjaime2 0c81299
              
                Add default configuration for Articulable Fork joints
              
              
                jjaime2 1d20fda
              
                Revert "Format forque.xacro using xmllint"
              
              
                jjaime2 6efbe95
              
                Add end_effector_tool configuration, remove use_forque configuration
              
              
                jjaime2 1ac9d62
              
                Conditionally modify fork URDF based on end_effector_tool
              
              
                jjaime2 f463f1f
              
                Collapse XACRO elements
              
              
                jjaime2 b0a0e67
              
                More formatting
              
              
                jjaime2 1ef30d9
              
                Rename forkTine_to_forque to af_forque_joint
              
              
                jjaime2 5e961d8
              
                Decouple ADAs description into a macro that is explicitly instantiate…
              
              
                jjaime2 e2b14e8
              
                Merge branch 'main' into jjaime2/articulable_fork_description
              
              
                jjaime2 9c4ac8c
              
                Run pre-commit
              
              
                jjaime2 0967dad
              
                Remove actuator, transmission, and gazebo configurations
              
              
                jjaime2 5c68db3
              
                Merge branch 'main' into jjaime2/articulable_fork_description
              
              
                jjaime2 703ff69
              
                Add comments explaining macro imports in ada.xacro
              
              
                jjaime2 8acecd5
              
                Remove base_parent argument for ada macro, use root by default
              
              
                jjaime2 9f2f8f7
              
                Rename dummy_default_value to forque_assembly_dummy_default_value
              
              
                jjaime2 6b6e5ba
              
                Fix indentation
              
              
                jjaime2 be387a5
              
                Revert change to FTMount joint_origin_xyz
              
              
                jjaime2 a5b43c5
              
                Remove broken error messages, remove fixed parameter for forque_assem…
              
              
                jjaime2 4d3c85c
              
                Add comment for ada macro
              
              
                jjaime2 753d5c7
              
                Fix axis of rotation for af_joint_2
              
              
                jjaime2 95f6531
              
                Adjust af_joint_base joint_origin_xyz
              
              
                jjaime2 6d39728
              
                Remove slight rotation of forkHandle_to_FTMount joint since updated f…
              
              
                jjaime2 f4aed22
              
                Adjust af_joint_base joint_origin_xyz
              
              
                jjaime2 91e15b1
              
                Revert "Remove slight rotation of forkHandle_to_FTMount joint since u…
              
              
                jjaime2 File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
            Binary file not shown.
          
    
            Binary file not shown.
          
    
            Binary file not shown.
          
    
            Binary file not shown.
          
    
            Binary file not shown.
          
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| <?xml version="1.0"?> | ||
| <robot xmlns:xi="http://www.w3.org/2001/XInclude" | ||
| xmlns:gazebo="http://playerstage.sourceforge.net/gazebo/xmlschema/#gz" | ||
| xmlns:model="http://playerstage.sourceforge.net/gazebo/xmlschema/#model" | ||
| xmlns:sensor="http://playerstage.sourceforge.net/gazebo/xmlschema/#sensor" | ||
| xmlns:body="http://playerstage.sourceforge.net/gazebo/xmlschema/#body" | ||
| xmlns:geom="http://playerstage.sourceforge.net/gazebo/xmlschema/#geom" | ||
| xmlns:joint="http://playerstage.sourceforge.net/gazebo/xmlschema/#joint" | ||
| xmlns:controller="http://playerstage.sourceforge.net/gazebo/xmlschema/#controller" | ||
| xmlns:interface="http://playerstage.sourceforge.net/gazebo/xmlschema/#interface" | ||
| xmlns:rendering="http://playerstage.sourceforge.net/gazebo/xmlschema/#rendering" | ||
| xmlns:renderable="http://playerstage.sourceforge.net/gazebo/xmlschema/#renderable" | ||
| xmlns:physics="http://playerstage.sourceforge.net/gazebo/xmlschema/#physics" | ||
| xmlns:xacro="http://www.ros.org/wiki/xacro" | ||
| name="ada"> | ||
|  | ||
| <xacro:arg name="end_effector_tool" default="fork" /> | ||
|  | ||
| <xacro:include filename="$(find ada_description)/urdf/ada.xacro" /> | ||
|  | ||
| <xacro:property name="root" value="root" /> | ||
| <xacro:property name="end_effector_tool" value="$(arg end_effector_tool)" /> | ||
| <xacro:ada end_effector_tool="${end_effector_tool}" /> | ||
|  | ||
| </robot> | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.