Skip to content

Fix: Clean up managers when delegate expert not found#11

Merged
FL4TLiN3 merged 2 commits intomainfrom
fix/delegate-expert-cleanup-on-error
Dec 4, 2025
Merged

Fix: Clean up managers when delegate expert not found#11
FL4TLiN3 merged 2 commits intomainfrom
fix/delegate-expert-cleanup-on-error

Conversation

@FL4TLiN3
Copy link
Contributor

@FL4TLiN3 FL4TLiN3 commented Dec 4, 2025

Summary

Test plan

  • Typecheck passes
  • Unit tests pass
  • E2E tests pass

Fixes: https://github.com/perstack-ai/perstack/pull/9/files#r2587142664


Note

Ensure initialized skill managers are closed when a delegate expert is missing during setup.

  • Runtime (packages/runtime/src/skill-manager/helpers.ts):
    • On missing delegate expert, close all initialized managers (mcp, interactive, and any prior delegate) before throwing.
    • Refactor delegate manager creation from mapping to a for loop accumulating DelegateSkillManager[] to enable early cleanup and error handling.
  • Release:
    • Changeset adds patch for @perstack/runtime with note on delegate cleanup (.changeset/fix-delegate-cleanup.md).

Written by Cursor Bugbot for commit e4b039a. This will update automatically on new commits. Configure here.

@vercel
Copy link

vercel bot commented Dec 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
perstack Ready Ready Preview Comment Dec 4, 2025 1:54am

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/runtime/src/skill-manager/helpers.ts 0.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@FL4TLiN3 FL4TLiN3 merged commit a6ab2b8 into main Dec 4, 2025
8 of 9 checks passed
@FL4TLiN3 FL4TLiN3 deleted the fix/delegate-expert-cleanup-on-error branch December 4, 2025 01:54
@github-actions github-actions bot mentioned this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant