Refactor: Share ExpertSelector across wizards#35
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ea07b7c to
f591e9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WizardExpertSelectorcomponent from duplicated implementationsExpertChoicetype to centralized typesExpertSelectorimplementations in all wizard apps (Publish, Status, Tag, Unpublish)Closes #26
Test plan
pnpm typecheckpassespnpm format-and-lintpassespnpm buildpassesNote
Introduce shared
WizardExpertSelectorand replace duplicated expert selection UIs in Publish, Status, Tag, and Unpublish apps.WizardExpertSelectorinpackages/tui/src/components/wizard-expert-selector.tsxand export viapackages/tui/src/components/index.ts.WizardExpertSelectorin:packages/tui/apps/publish/app.tsx(addshandleSelectto exit after selection).packages/tui/apps/status/app.tsx(uses shared selector for expert selection step).packages/tui/apps/tag/app.tsx(uses shared selector for expert selection step).packages/tui/apps/unpublish/app.tsx(uses shared selector for expert selection step).Written by Cursor Bugbot for commit f591e9f. This will update automatically on new commits. Configure here.