Refactor: Share VersionSelector across wizards#36
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
FL4TLiN3
force-pushed
the
refactor/share-version-selector
branch
from
5062307 to
7792b9f
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WizardExpertChoice,WizardVersionInfo) to consolidate duplicated type definitionsgetStatusColorutility function for reuse across wizard appsVersionSelectorcomponent with customizable title propRelated Issues
Closes #24
Closes #25
Closes #27
Test plan
pnpm typecheckpassespnpm testpassespnpm format-and-lintpassespnpm check-depspassespnpm buildpassesNote
Extracts a reusable VersionSelector component and updates status, tag, and unpublish wizards to use it (with optional custom title).
packages/tui/src/components/version-selector.tsx: New sharedVersionSelectorwith optionaltitleprop and keyboard navigation; usesgetStatusColor.VersionSelectorfrompackages/tui/src/components/index.ts.VersionSelectorimplementations with sharedVersionSelectorimport.titletoVersionSelector.@perstack/tui.Written by Cursor Bugbot for commit 7792b9f. This will update automatically on new commits. Configure here.