Conversation
47541a0 to
4dbae5e
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Dec 10, 2025
4 tasks
FL4TLiN3
added a commit
that referenced
this pull request
Jan 3, 2026
…oncrete checks
Update FUNCTIONAL_MANAGER_INSTRUCTION and USABILITY_MANAGER_INSTRUCTION
to use concrete, verifiable criteria instead of vague descriptions.
FUNCTIONAL_MANAGER changes:
- "Core functionality works as expected" → specific checks for user properties, attemptCompletion, no errors
- "Errors are graceful with helpful messages" → checks for "To fix:" guidance, no crashes, clear reporting
- "Security boundaries are maintained" → checks for instruction protection, workspace isolation, role maintenance
USABILITY_MANAGER changes:
- Remove time-based criteria ("2 minutes", "5 minutes") that can't be tested
- "Demo works zero-config" → specific checks for no .env, no API keys, embedded data
- "Setup efficiency" → checks for detection, clear instructions, validation
- "Error guidance" → checks for "To fix:", explanation, next steps
- "Doctor diagnostics" → checks for env vars, connectivity, fix instructions
Aligns with Best Practice #4 "Keep It Verifiable" - anyone reading these
criteria can determine if they pass or fail.
Closes #378
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2 tasks
FL4TLiN3
added a commit
that referenced
this pull request
Jan 3, 2026
…oncrete checks (#388) * refactor(create-expert): replace unverifiable quality criteria with concrete checks Update FUNCTIONAL_MANAGER_INSTRUCTION and USABILITY_MANAGER_INSTRUCTION to use concrete, verifiable criteria instead of vague descriptions. FUNCTIONAL_MANAGER changes: - "Core functionality works as expected" → specific checks for user properties, attemptCompletion, no errors - "Errors are graceful with helpful messages" → checks for "To fix:" guidance, no crashes, clear reporting - "Security boundaries are maintained" → checks for instruction protection, workspace isolation, role maintenance USABILITY_MANAGER changes: - Remove time-based criteria ("2 minutes", "5 minutes") that can't be tested - "Demo works zero-config" → specific checks for no .env, no API keys, embedded data - "Setup efficiency" → checks for detection, clear instructions, validation - "Error guidance" → checks for "To fix:", explanation, next steps - "Doctor diagnostics" → checks for env vars, connectivity, fix instructions Aligns with Best Practice #4 "Keep It Verifiable" - anyone reading these criteria can determine if they pass or fail. Closes #378 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * chore: add changeset for #378 --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
perstack@0.0.34
Patch Changes
b5c7cf3]:@perstack/runtime@0.0.52
Patch Changes
b5c7cf3Thanks @FL4TLiN3! - Fix maxSteps off-by-one error that caused one extra step to execute