Refactor: Use KEY_HINTS constants in wizard apps#44
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| )} | ||
| <Box marginTop={1}> | ||
| <Text dimColor>↑↓ navigate · enter select · esc back · q quit</Text> | ||
| <Text dimColor>{`${KEY_HINTS.NAVIGATE} ${KEY_HINTS.SELECT} ${KEY_HINTS.ESC_BACK} ${KEY_HINTS.QUIT}`}</Text> |
There was a problem hiding this comment.
Bug: Incomplete refactoring creates inconsistent hint formats within wizards
The refactoring to use KEY_HINTS constants is incomplete. The shared components WizardExpertSelector and VersionSelector still display hints in the old format (↑↓ navigate · enter select · q quit), while the app-specific components now use the new format (↑↓:Navigate Enter:Select Esc:Back q:Quit). This creates an inconsistent user experience within the same wizard flow, directly contradicting the PR's goal to "ensure consistent hint format across all wizard apps."
Additional Locations (2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QUIT,ESC_BACK, andCONFIRMconstants toKEY_HINTSin constants.tsapps/status/app.tsx,apps/tag/app.tsx, andapps/unpublish/app.tsxwithKEY_HINTSconstantskey:Actionformat)Closes #40
Test plan
Note
Replace hardcoded key hint text in status/tag/unpublish wizards with KEY_HINTS and add QUIT, ESC_BACK, and CONFIRM constants.
packages/tui/src/constants.ts): AddKEY_HINTS.QUIT,KEY_HINTS.ESC_BACK,KEY_HINTS.CONFIRMfor standardized keyhint labels.packages/tui/apps/status/app.tsx: Replace inline key-hint strings withKEY_HINTSconstants.packages/tui/apps/tag/app.tsx: UseKEY_HINTSfor confirm/back/quit hints; maintainctrl+qnote.packages/tui/apps/unpublish/app.tsx: UseKEY_HINTSfor navigation/select/back/quit hints.key:Actionhint format across wizard screens.Written by Cursor Bugbot for commit a6cd820. This will update automatically on new commits. Configure here.