Refactor: Move E2E tests to dedicated workflow for release branch#72
Merged
Refactor: Move E2E tests to dedicated workflow for release branch#72
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
|
||
| on: | ||
| push: | ||
| branches: [changeset-release/main] |
There was a problem hiding this comment.
Bug: E2E tests no longer gate npm publish
The refactoring decouples E2E tests from the publish workflow in a way that removes the safety gate. Previously, E2E tests ran in release.yml before the changesets action, blocking publish on failure. Now E2E tests run on changeset-release/main independently, but when the Version PR is merged to main, release.yml triggers and can publish to npm regardless of E2E test results. The E2E workflow status doesn't prevent merging or publishing—a broken package could be released if someone merges the Version PR while E2E tests are failing.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release.yml(runs on every main push)e2e.ymlworkflow that runs only onchangeset-release/mainbranchMotivation
Previously, E2E tests ran on every push to main, which was inefficient:
New Flow
Test plan
Note
Moves E2E tests from
release.ymlto a newe2e.ymlworkflow triggered onchangeset-release/main./.github/workflows/e2e.ymlto run E2E tests on pushes tochangeset-release/main./.github/workflows/release.ymlby removing the E2E test step from the release job.Written by Cursor Bugbot for commit 0ba95d1. This will update automatically on new commits. Configure here.