Skip to content

Refactor: Move E2E tests to dedicated workflow for release branch#72

Merged
FL4TLiN3 merged 1 commit intomainfrom
refactor/e2e-workflow-for-release
Dec 8, 2025
Merged

Refactor: Move E2E tests to dedicated workflow for release branch#72
FL4TLiN3 merged 1 commit intomainfrom
refactor/e2e-workflow-for-release

Conversation

@FL4TLiN3
Copy link
Contributor

@FL4TLiN3 FL4TLiN3 commented Dec 8, 2025

Summary

  • Remove E2E tests from release.yml (runs on every main push)
  • Add new e2e.yml workflow that runs only on changeset-release/main branch

Motivation

Previously, E2E tests ran on every push to main, which was inefficient:

  • Unnecessary API costs for non-release builds
  • Longer CI times for regular PRs

New Flow

PR merged → main
    ↓
release.yml → Creates/updates Version PR (changeset-release/main)
    ↓
e2e.yml → Runs E2E tests on changeset-release/main
    ↓
E2E passes → Safe to merge Version PR
    ↓
Version PR merged → npm publish

Test plan

  • Verify E2E workflow triggers on changeset-release/main push
  • Verify release workflow no longer runs E2E tests

Note

Moves E2E tests from release.yml to a new e2e.yml workflow triggered on changeset-release/main.

  • CI Workflows:
    • Add /.github/workflows/e2e.yml to run E2E tests on pushes to changeset-release/main.
    • Update /.github/workflows/release.yml by removing the E2E test step from the release job.

Written by Cursor Bugbot for commit 0ba95d1. This will update automatically on new commits. Configure here.

@vercel
Copy link

vercel bot commented Dec 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
perstack Ignored Ignored Dec 8, 2025 7:03pm

@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@FL4TLiN3 FL4TLiN3 merged commit 856ef6e into main Dec 8, 2025
9 checks passed
@FL4TLiN3 FL4TLiN3 deleted the refactor/e2e-workflow-for-release branch December 8, 2025 19:06

on:
push:
branches: [changeset-release/main]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: E2E tests no longer gate npm publish

The refactoring decouples E2E tests from the publish workflow in a way that removes the safety gate. Previously, E2E tests ran in release.yml before the changesets action, blocking publish on failure. Now E2E tests run on changeset-release/main independently, but when the Version PR is merged to main, release.yml triggers and can publish to npm regardless of E2E test results. The E2E workflow status doesn't prevent merging or publishing—a broken package could be released if someone merges the Version PR while E2E tests are failing.

Additional Locations (1)

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant