Cleanup #36
Merged
Cleanup #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix redundant field names in struct initializations - Remove redundant serde_json import in scenefile.rs - Fix collapsible else-if blocks in bbox.rs - Remove needless return statements in box_terrain.rs - Fix syntax error in ocean.rs amplitude function 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fix needless return statements in various material modules - Fix redundant field names in struct initializations - Fix indentation issues and syntax errors in rendercontext.rs - Update legacy numeric constants with newer syntax - Fix conditional return structure to avoid compiler errors 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fix needless returns in procedural modules - Fix manual_clamp warnings by using .clamp() in color.rs and noise.rs - Fix wrong_self_convention warnings in Color methods - Fix op_ref warnings by removing unnecessary references - Fix indentation and syntax errors in participatingmedia.rs - Fix let_and_return in noise.rs - Fix needless borrow issues in rendercontext.rs - Convert write! with newline to writeln! in paint.rs - Fix redundant closure with map/Arc::new in fireworks.rs - Fix unnecessary casts in rendercontext.rs 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fix missing enclosing brace for HomogenousFog::intersects function - Fix variable resolution issue in Color class for as_vec and as_u8 methods - Fix semicolon in FireworkMaterial::scatter that was causing return type mismatch - Update method invocations to use the renamed methods 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove needless return statements - Remove unnecessary references - Replace if-return chains with if-else expressions - Fix control flow in entry_face and exit_face methods 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…n functions.rs, and remove legacy numeric constants in several files
- Replace &Vec with &[T] in octree.rs and ocean.rs - Replace std::f64 legacy constants with f64::constants in infinite.rs and repeating_mesh.rs - Fix documentation comments in ocean.rs - Add type definition for complex return type in ocean.rs
- octree.rs: Use _max and _min in recursive call - ocean.rs: Fix transpose function to use to_vec() - fireworks.rs and csg.rs: Add explicit Vec type for collected Arc values
- Replace if-else chains with logical expressions in BBox methods - Replace while loop with while-let in csg.rs - Fix documentation comment in model.rs - Suppress too_many_arguments warning in create_particles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vibe code fixes to lint errors and compile warnings.