Refurbish #27
Refurbish #27
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Keep! |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
keep! |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Keep |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
keep! |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
keep |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR refurbishes the WebFinger WordPress plugin by introducing a major version bump to 4.0.0 and implementing a namespace-based architecture. The changes modernize the codebase by organizing classes under the Webfinger namespace and improving code structure.
- Migrates from procedural function-based architecture to namespaced class-based structure
- Splits functionality into dedicated classes (User, Admin, Legacy) with static initialization methods
- Updates WordPress compatibility to version 6.7 and introduces user profile management features
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| webfinger.php | Main plugin file updated with namespace and refactored initialization |
| templates/profile-settings.php | New user profile settings template for WebFinger resource management |
| readme.md | Version bump to 4.0.0 and WordPress 6.7 compatibility |
| languages/webfinger.pot | Added translation strings for new profile settings |
| includes/functions.php | Updated function calls to use namespaced classes and improved comparisons |
| includes/deprecated.php | New file with empty class stubs for backward compatibility |
| includes/class-webfinger.php | Refactored with namespace and static initialization method |
| includes/class-user.php | New class handling user-related WebFinger functionality |
| includes/class-legacy.php | Refactored legacy support with namespace |
| includes/class-admin.php | New admin interface class for user profile management |
| docker-compose.yml | Added platform specification for cross-platform compatibility |
| */ | ||
| public static function is_same_host( $uri ) { | ||
| $blog_host = parse_url( home_url(), PHP_URL_HOST ); | ||
| return true; |
There was a problem hiding this comment.
The is_same_host method always returns true instead of performing the actual host comparison. This bypasses all host validation and creates a security vulnerability.
| return true; |
| ! empty( $user->user_url ) // && | ||
| //self::is_same_host( $user->user_url ) |
There was a problem hiding this comment.
The commented out code //self::is_same_host( $user->user_url ) should either be implemented or removed entirely rather than left as a comment.
| ! empty( $user->user_url ) // && | |
| //self::is_same_host( $user->user_url ) | |
| ! empty( $user->user_url ) |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
No description provided.