feat(pfsense_dns_resolver.py): Option to preserve unbound hosts #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratus-ss
force-pushed
the
preserve_unbound_hosts
branch
from
9616417 to
11454b3
Compare
|
hey @opoplawski can we merge this guy in? |
opoplawski
force-pushed
the
preserve_unbound_hosts
branch
2 times, most recently
from
b433b02 to
e0ec25d
Compare
Contributor
|
Sorry, I'll try to find some time soon to review this. In the mean time I managed to fix the CI so there are some things to clean up there. |
Author
|
I made a pep8 push today. Just need the CI to run to confirm |
opoplawski
force-pushed
the
preserve_unbound_hosts
branch
2 times, most recently
from
ce6264c to
1bdc637
Compare
…rve: true, the current dns settings will be preserved and appended to and not overwritten
opoplawski
force-pushed
the
preserve_unbound_hosts
branch
from
7b2382d to
7875e7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new option to preserve hosts, domains and custom options instead of wiping them out eat time the play runs.
Fixes #153
As requested, by default this option is set to false.
The new option looks like this
I wondered whether this should be a required setting?
I added a fixture for the tests, however I wasn't able to come up with how to test this appropriately. Sometimes I am a little slow untangling test cases to base off of. I don't mind doing the work but I probably need a poke in the right direction. I took several swings at this but didn't get anywhere.