fix(pfsense_rule): properly validate ipv6 #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SUedurable
commented
Nov 30, 2025
Comment on lines
223
to
242
|
|
||
| @staticmethod | ||
| def is_ipv6_address(address): | ||
| """ test if address is a valid ipv6 address """ | ||
| try: | ||
| addr = ip_address(u'{0}'.format(address)) | ||
| return isinstance(addr, IPv6Address) | ||
| except ValueError: | ||
| pass | ||
| return False | ||
|
|
||
| @staticmethod | ||
| def is_ipv6_network(address, strict=True): | ||
| """ test if address is a valid ipv6 network """ | ||
| try: | ||
| addr = ip_network(u'{0}'.format(address), strict=strict) | ||
| return isinstance(addr, IPv6Network) | ||
| except ValueError: | ||
| pass | ||
| return False |
Author
There was a problem hiding this comment.
Here we can surely reference the same (original) functions in pfsense_module but I'm not experienced enough with this project to figure out how.
Contributor
|
Thanks for the PR. Just a quick note that it's best to create a new branch when working on changes rather than working directly on master. |
Do not split on : if parsing ipv6. This also assumes you're not going to use ipv6:port syntax which is deprecated Adds tests Fixes #219
Author
|
Will do next time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #219. It probably solves similar issues on other modules with IP:port validation.
I first added tests to prove it didn't work with IPv6 network and IP.
Then implemented the fix.
This patch can surely be improved in some places, especially where duplicating code.
When
:portsyntax is dropped, this patch can probably be removed.The new added tests now pass on my fork and I could test locally that it indeed fixes my issue.