adding copy systen info into clipboard under debugger right click menu #1251
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| Class { | ||
| #name : 'SindarinCopyOsInfo', | ||
| #superclass : 'SindarinCommand', | ||
| #category : 'NewTools-Sindarin-Commands', | ||
| #package : 'NewTools-Sindarin-Commands' | ||
| } | ||
|
|
||
| { #category : 'default' } | ||
| SindarinCopyOsInfo class >> defaultDescription [ | ||
|
|
||
| ^ 'Copy to clipboard system information and Pharo image version' | ||
| ] | ||
|
|
||
| { #category : 'initialization' } | ||
| SindarinCopyOsInfo class >> defaultIconName [ | ||
| ^#smallCopy | ||
| ] | ||
|
|
||
| { #category : 'default' } | ||
| SindarinCopyOsInfo class >> defaultName [ | ||
| <toolbarExtensionDebugCommand: 50> | ||
| <codeExtensionDebugCommand:1 > | ||
| ^ 'Copy system information' | ||
| ] | ||
|
|
||
| { #category : 'executing' } | ||
| SindarinCopyOsInfo >> execute [ | ||
|
|
||
| Clipboard clipboardText: self systemInfo. | ||
| ] | ||
|
|
||
| { #category : 'as yet unclassified' } | ||
|
|
||
| SindarinCopyOsInfo >> systemInfo [ | ||
|
|
||
| ^ Smalltalk os platformName, | ||
| Smalltalk os version , | ||
| Character space asString , | ||
| Smalltalk os subtype , | ||
| Character cr asString, | ||
| Smalltalk image lastUpdateString | ||
| ] | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really specific to Sindarin to copy some infos?
Seems like something more general than Sindarin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we want to have it on all menus.
According to the issue we want to be able to report system info from a debugger window when an error is raised, to help documenting a new issue about it.
This way we avoid carrying an extra entry in the right click menu elsewhere where it isn't used as much as on a debugger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you Faouzi but what Cyril means is that it maybe should be at the "general debugger" level rather than on Sindarin.
That's another subject but in my opinion Sindarin should be removed from the system, and be an external, optional project. If that ever happens, should we still want to have the feature you propose available in the debugger?
If that is so, then it just means you have to rename and move your command class in the debugger packages with other commands ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah now i see what you mean, in this case i'll try to move the command into the debugger. Thanks for clearing this up for me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Steven about sindarin, let us know. I liked the idea of being able to script the debugger.
What I can tell you is that with debug info we paid attention not to break it.
If it is out of Pharo, it will be probably difficult to maintain it. Now I think that for debug info we will not do more changes. so may be we could remove it when the debugger can use offlinedebuginfo like that it will be in a good shape for the future.