fix magic id optimization + portals #4106
Merged
+62
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #4095. The initial render does not contain the magic id attributes, but we never updated the template element itself. When a cloned tree was restored, the template therefore contained outdated nodes that were missing the magic id attribute. Then, when an update with phx-skip arrived, we would replace it as the DOM node was missing its magic id.
SteffenDE
force-pushed
the
sd-issue-4095
branch
from
3c8c4ae to
03b2ba4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4095.
The initial render does not contain the magic id attributes, but we never updated the template element itself. When a cloned tree was restored, the template therefore contained outdated nodes that were missing the magic id attribute.
Then, when an update with phx-skip arrived, we would replace it as the DOM node was missing its magic id.