Combine structures Implemented #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a combine method to the Structure class, allowing one structure to be merged into another at a specified position. Also improves handling of structure voids for the `get_block` method
Introduces a new test case to verify the behavior of the Structure.combine method, ensuring correct block placement and handling of overlaps. Also adds minor formatting improvements for black linter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the
Structureclass in themcstructuremodule as per #23 , including improvements to block handling, a new method for combining structures, and corresponding tests to ensure functionality.Enhancements to
Structureclass:get_blockto handle negative indices by returning aminecraft:structure_voidblock if the index is negative.combinemethod to merge two structures, ensuring proper handling of palettes and size.(
src/mcstructure/__init__.py)Test additions:
test_combine, to validate the behavior of thecombinemethod, ensuring proper integration of two structures. (tests/test_structure.py)