Skip to content
This repository was archived by the owner on Apr 4, 2026. It is now read-only.

Added links to album(s) on photo detail page. #900#1047

Open
n8d wants to merge 1 commit intophoto:developmentfrom
n8d:development
Open

Added links to album(s) on photo detail page. #900#1047
n8d wants to merge 1 commit intophoto:developmentfrom
n8d:development

Conversation

@n8d
Copy link
Copy Markdown

@n8d n8d commented Dec 30, 2012

Very open to suggestions on implementation. Just getting my feet wet here :)

@jmathai
Copy link
Copy Markdown
Member

jmathai commented Dec 31, 2012

Thanks @n8d! Adding comments to your commit.

We're doing an overhaul to the theme so that code might be discarded but the code from the PhotoController would still be relevant.

@n8d
Copy link
Copy Markdown
Author

n8d commented Dec 31, 2012

Sounds good @jmathai, and thanks for the tips. I'll make some edits when I get back to my dev environment in a couple days.

Where is the theme overhaul happening? Is that why the theme templates are included in .gitignore? I had to force my commit so wasn't sure that was the correct template.

@jmathai
Copy link
Copy Markdown
Member

jmathai commented Dec 31, 2012

Check the fabrizio1.0 branch. We're moving away from having multiple themes to having one really good theme and customizing it via CSS instead of having separate markup/css/js for it.

https://github.com/photo/frontend/tree/fabrizio1.0

@n8d
Copy link
Copy Markdown
Author

n8d commented Dec 31, 2012

Cool, I'll check it out soon.

@jmathai
Copy link
Copy Markdown
Member

jmathai commented Apr 26, 2013

@n8d Let me know if you had a look at the new theme. I think adding this link is a good feature and would love to merge it in :).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants