New gallery layout without image crop#1291
Open
httpdispatch wants to merge 3 commits intophoto:masterfrom
Open
New gallery layout without image crop#1291httpdispatch wants to merge 3 commits intophoto:masterfrom
httpdispatch wants to merge 3 commits intophoto:masterfrom
Conversation
Member
|
I kinda like the no crop feature. |
Member
|
@hfiguiere I haven't looked at the code from @httpdispatch but if it does what he claims then it provides a foundation to provide various and adaptive layouts for photos. |
Author
|
@jmathai is there any chances this will be reviewed someday? |
Member
|
@httpdispatch Sorry about not getting to this. No estimate but would like to get to reviewing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current layout crops images like this
Proposed layout doesn't crop images. It adjusts row height instead of. Also it keeps images aspect ratio
Row height can be customised via defaultImageHeight and maxImageHeight parameters