Proposed fix for #1576 - photos sorting behaviour consistent for Gallery, Album and Tag views

[ashwingj]

The fix was made based on the following observations

• Inconsistency between how sorting behaviour is applied between the initial PhotoController::List_ action and subsequent javascript ApiPhotoController::List_ actions
  • PhotoController never set IsAlbum and IsTag variables and hence code to apply dateTaken,asc sorting behaviour for Tag and Album was never executed (if condition never evaluated to true). Additional evidence was the 'Variable not defined' errors for IsAlbum and IsTag in the error log.
  • Javascript applied dateTaken,asc sorting for Album only and dateUploaded,desc for all (including Tags)

Fix: Proposed a method of detecting IsAlbum and removed IsTag (to be consistent with Javascript behaviour).

• this->permissions->canUpload call in the photos-sub-heading.php file started throwing 'definition not found errors' as soon as we fixed the IsAlbum variable problem
  • No canUpload method found in any source file. No idea what the permissions class was either.

Fix: Commenting out for the time being until able to figure out what this is ... repo owners, some guidance would be welcome here.