-
Notifications
You must be signed in to change notification settings - Fork 2
fix: composer dependency for phpdb #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Julien Guittard <julien.guittard@me.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR :)
Let's go with
"php-db/phpdb": "^0.1.0"fix: fixture loader return types in UT Signed-off-by: Julien Guittard <julien.guittard@me.com>
|
Let's go! |
|
Meh, sometimes I hate psalm. You will need to reset the baseline for psalm before it will pass :( See composer.json "sa-set-baseline": "psalm --set-baseline",For whatever reason in psalm 6 I have not been able to get --update-baseline to work as expected so just run set baseline twice and it should clear that issue. Also, if you will retarget this PR at the 0.1.1 branch it should create a merge_up branch for merging into 0.2.0 |
Signed-off-by: Julien Guittard <julien.guittard@me.com>
|
Haha, psalm can be very picky fore sure, I'd rather revert the fixes I made to |
…\FixtureLoader Signed-off-by: Julien Guittard <julien.guittard@me.com>
|
Well, the situation is that either the typing needs to be resolved (and the baseline reset) or a annotation added to the FixtureLoader. If you can just retarget this to the 0.1.1 branch (it needs fixed as well). Then I will merge it since I will shortly be opening a PR to address a few other issues I will include the typing fixes for 0.2.0. The CI/CD pipeline really is just a sanity check at the moment. We will be VERY strict on that once we reach 1.0 of course. But, this is pre beta code so it should always be considered broken :) The real issue is that were just now really getting to a point where were ready for PR's. :) There has been a ton of work required just to split the code into the satellite packages and refactor the entry to the lib using factories backed by SM4. My todo list for this weekend already had this change on it but I would much rather merge the work from you rather than just include it in a PR. You did the work :) Just remember, this code will be influx for at least another month or so while we remove code from phpdb that is moving to satellite packages. There is a scope of work and several tracking issues in the various repo's that I try my best to keep updated... It's just A LOT to keep track of on a daily basis. |
|
I am aware about the tons of things that need to be addressed. I'd be happy to help, even though at the very moment the core topics are already handled. |
Fixes #26