-
Notifications
You must be signed in to change notification settings - Fork 6
Refactor sql abstraction #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 158 commits
Commits
Show all changes
161 commits
Select commit
Hold shift + click to select a range
6f16087
Fixed test for expected type of identifier (which is default)
simon-mundy f98e6b3
Fixed test for expected type of identifier (which is default)
simon-mundy 8666511
Integration of new Argument and ArgumentType classes
simon-mundy fff303b
Continuing refactor
simon-mundy d6d2c46
Updating Unit Testing for correct syntax
simon-mundy 4e34b7a
Continuing updates to refactoring
simon-mundy e04e45a
Continuing updates to refactoring
simon-mundy ddf1677
Updating Unit Testing for correct syntax
simon-mundy 6e67b58
WIP
simon-mundy b847d67
Finalise unit testing for SQL
simon-mundy e2bd4d6
Finalise unit testing for SQL
simon-mundy 7342f9a
Finalise unit testing for SQL
simon-mundy dd0449b
Finalise unit testing for SQL
simon-mundy f5f96dd
Finalise unit testing for SQL
simon-mundy 39531d4
Finalise unit testing for SQL
simon-mundy e0b243b
Merge remote-tracking branch 'origin/3.0.x' into refactor-sql-abstrac…
simon-mundy 5ad7368
Added strict types to all project files
simon-mundy 3ec866f
Change namespace and components to PhpDb
simon-mundy c390c31
Change namespace and components to PhpDb
simon-mundy b00a4b3
This merge brings in the latest changes from 0.3.x including:
simon-mundy 8c15bbb
Fix merge issues: restore TYPE constants and remove gitignore copy
simon-mundy 0f91a95
Complete ExpressionData migration in AbstractSql and fix namespace re…
simon-mundy 4165fd8
Fix AbstractSourceTest mock to include loadSchemaData method
simon-mundy 1ae5c59
Replace ExpressionInterface::TYPE_* constants with ArgumentType enum …
simon-mundy dc4e7fc
Update test files to use ArgumentType enum instead of TYPE constants
simon-mundy d9710b0
Fix SelectTest to use Argument objects in assertions
simon-mundy da6d56e
Fixes to tests
simon-mundy b14c5db
Added deprecation notes for constants
simon-mundy ae823e0
Added PhpDbTest\AdapterTestTrait for convenience
simon-mundy c0fd1a2
Added PhpDbTest\AdapterTestTrait for convenience
simon-mundy 0d9c7de
Added PhpDbTest\AdapterTestTrait for convenience
simon-mundy 56758c8
In commit b847d674 (April 28, 2025), getter methods were accidentally
simon-mundy b44cd25
Merge remote-tracking branch 'origin/refactor-sql-abstraction' into r…
simon-mundy 8b2451d
Reverted unncesseary param name refactor
simon-mundy 669d9c0
Update Metadata unit testing
simon-mundy a4c1049
Further improvements in typing
simon-mundy 7e28fa1
Further improvements in typing
simon-mundy f0596c3
Improved test coverage for Metadata and Sql components
simon-mundy 0823157
Update Metadata unit testing
simon-mundy 6b1b66f
Fixes for markdownlinter in docs
simon-mundy f7520e6
Added new Test Assets
simon-mundy ed19a42
Updated tests
simon-mundy f7cb1e1
Updated phpunit.xml for both CI and project
simon-mundy 6bdd4aa
Merge remote-tracking branch 'origin/refactor-sql-abstraction' into r…
simon-mundy 426ba03
Updated phpunit.xml for both CI and project
simon-mundy 8acc378
Updated phpunit.xml for both CI and project
simon-mundy f9c2654
QA fixes
simon-mundy 659be53
QA fixes
simon-mundy d478879
QA fixes
simon-mundy ff920ab
QA fixes
simon-mundy 6ca89b5
Strong typing and rector improvements
simon-mundy 2233b02
Strong typing and rector improvements
simon-mundy b96bd33
Strong typing and rector improvements
simon-mundy 0cf133b
Strong typing and rector improvements
simon-mundy 4807d3c
Strong typing and rector improvements
simon-mundy 30b9794
Strong typing and rector improvements
simon-mundy b9bdaf1
Undo change for canCreate
simon-mundy 2ebc567
Fixed incorrect typing for parameters
simon-mundy 77554cc
Remove superfluous nullable strings from setters
simon-mundy fb7e28e
Reverted constructor of Platform.php
simon-mundy d1d4121
Reverted constructor of Platform.php
simon-mundy b96fff6
Refactored concrete Sql\Platform\Platform with no default decorators
simon-mundy 3096c01
Comprehensive refactoring of tests
simon-mundy 9739c22
Implement new Argument and ArgumentType
simon-mundy d9c00de
Migrate SQL classes to new Argument factory pattern
simon-mundy 5a3c3ef
Update ExpressionPart and ExpressionData to use ArgumentInterface
simon-mundy 6faf2cd
Implement new Argument and ArgumentType
simon-mundy 7c692a8
Refactoring to new Argument usage
simon-mundy f17af37
Refactoring to new Argument usage
simon-mundy 78c842a
This commit removes the adapter manager and rewires dependency mappin…
tyrsson 9b816fa
This name change is solely to provide consistency across all components.
tyrsson 82c0865
Actually this factory should not be provided by phpdb
tyrsson ea8b11a
Allow laminas service manager v3
tyrsson d1b4935
Add setObjectPrototype to ResultSetInterface
tyrsson 889f39e
Signed-off-by: Joey Smith <jsmith@webinertia.net>
tyrsson 247e4ff
Improve ResultSetInterface implementations
tyrsson 2d72183
Change singature for new method
tyrsson d8b26ef
Merge remote-tracking branch 'origin/0.4.x' into refactor-sql-abstrac…
simon-mundy 6676f4a
Refactoring to new Argument usage
simon-mundy f4639b7
Code reformatting
simon-mundy 2f0115f
Code reformatting
simon-mundy 1c25d05
Code reformatting
simon-mundy c16d5e3
Code reformatting
simon-mundy 8f8f4e0
Continued with revision for PR#87
simon-mundy 496e32c
Final fixes for PR#87
simon-mundy 71a8e15
Final fixes for PR#87
simon-mundy 22a08a6
Migrate SQL classes to new Argument factory pattern
simon-mundy a74f3c6
Update ExpressionPart and ExpressionData to use ArgumentInterface
simon-mundy 6f8bb3e
Implement new Argument and ArgumentType
simon-mundy ff1a22b
Refactoring to new Argument usage
simon-mundy 9d665cc
Refactoring to new Argument usage
simon-mundy 9725b64
This commit removes the adapter manager and rewires dependency mappin…
tyrsson 2ef2c54
This name change is solely to provide consistency across all components.
tyrsson a9c3422
Actually this factory should not be provided by phpdb
tyrsson a35f633
Allow laminas service manager v3
tyrsson 2c42725
Add setObjectPrototype to ResultSetInterface
tyrsson e328395
Signed-off-by: Joey Smith <jsmith@webinertia.net>
tyrsson b0204f3
Improve ResultSetInterface implementations
tyrsson c306df7
Change singature for new method
tyrsson 8879017
This commit removes the adapter manager and rewires dependency mappin…
tyrsson aae67d6
Add setObjectPrototype to ResultSetInterface
tyrsson 61c8278
Signed-off-by: Joey Smith <jsmith@webinertia.net>
tyrsson 3497b82
Improve ResultSetInterface implementations
tyrsson e8edacc
Change singature for new method
tyrsson f2afdb7
Missed deprecation
tyrsson 45756fa
fix property name
tyrsson 03172f6
Refactoring to new Argument usage
simon-mundy 9dd97c5
Code reformatting
simon-mundy d37368f
Code reformatting
simon-mundy ae051dc
Code reformatting
simon-mundy 79ec355
Code reformatting
simon-mundy 0249297
Continued with revision for PR#87
simon-mundy c373b07
Final fixes for PR#87
simon-mundy 700341b
Final fixes for PR#87
simon-mundy 5dd50a5
Merge branch 'refactor-sql-abstraction' of github.com:/php-db/phpdb i…
simon-mundy 94a31ce
Fix for PredicateSet not properly allowing Expressions
simon-mundy c86d799
Added tests for ensuring that ExpressionInterface can be added to any…
simon-mundy 87323cd
Added tests for ensuring that ExpressionInterface can be added to any…
simon-mundy 666ab27
Added test benchmarks for Argument
simon-mundy 3b8948b
Updated lock file
simon-mundy 9ed07da
Re-instated missing method
simon-mundy 20eca80
Refactored to use instances of Argument types
simon-mundy c11c21e
Made constants final
simon-mundy 6f22920
Made constants final in documentation
simon-mundy e609b3e
Minor improvement with promoted properties Literal.php
simon-mundy 4c6f1f8
Documentation linting fixes
simon-mundy 58ea514
Minor const fixes
simon-mundy 55c236c
Major refactor removing ExpressionData/Parts
simon-mundy c196a66
Major refactor removing ExpressionData/Parts
simon-mundy b092584
Convert factory to instances
simon-mundy 5e61737
Compare instances instead of ENUM types for performance
simon-mundy b38dc1d
Minor cleanup of string preparation
simon-mundy b8b2da5
Lazy-instantiation of Predicates for AbstractSql classes
simon-mundy 6121fe7
Ensure flattenExpression is optimised for early return
simon-mundy 4dbd16b
Further speed improvements
simon-mundy d8649f4
Cleanup loop for speed
simon-mundy a5ba11c
Reoordered for best case match first->last
simon-mundy 21f4a92
Moved common expression values into processExpression to save overhead
simon-mundy bf684ec
Ensure all value types match
simon-mundy 2c77779
Refactored buildSqlString to remove redundant assignments and params
simon-mundy e008741
Removed scratch benchmark file
simon-mundy 188927d
Code improvements and readability
simon-mundy 2cb2f30
Code improvements and readability
simon-mundy ae22b6a
Code improvements and readability
simon-mundy 6ecb436
Code improvements and readability
simon-mundy 30f84c8
Remove phpbench from CI (mistakenly added)
simon-mundy fb2e8e9
More code cleaning for speed optimisation
simon-mundy 99a8733
More code cleaning for speed optimisation
simon-mundy b90a3bc
Fix for CI
simon-mundy d27a6ab
Fix for CI
simon-mundy 4f5a61b
Minor string optimisation
simon-mundy 5d4e329
Remove testing comments
simon-mundy c397d29
Re-ordered interface argument typing
simon-mundy 3abda14
Refactored Argument types to provide spec
simon-mundy 5f2a13d
Removed superfluous docblock returns for fluent methods
simon-mundy a3fbcc2
Fixed unnecessary ternary operation
simon-mundy 5fb721c
Minor formatting fixes
simon-mundy d97a78f
Added correct return type (void)
simon-mundy 66ff73f
Merge branch '0.4.x' into refactor-sql-abstraction
simon-mundy 2280f9b
Added docblock typing for SMv3 and SMv4 compatibility
simon-mundy ffcf5e4
Fixed PHPStan baseline
simon-mundy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.