Change the context to be an unsealed array
#23
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the
contextkey of thelog_record_arraytype from a sealed array to an unsealed one.Currently,
$logger->records[0]['context']['foo']results in an error in PHPStan and Pslam because thecontextkey is defined to only ever have (at most) anexceptionkey, but nothing else. This change makes thecontextarray unsealed, meaning it can hold keys other thanexception.Fixes #17
This change is IMO a better solution than #21 which widens the type too far (
array<array-key, mixed>).