Fix: check for EOF when reading from socket #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we only check for EOF when reading in blocking mode. The client uses non-blocking reads most of the time though, such that we need to also check for EOF in those cases.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull request overview
This PR addresses a bug where EOF (End of File) conditions on the socket were only detected during blocking reads, not during non-blocking reads which are used most of the time by the client. The fix adds an upfront EOF check in the readFromSocket() method to detect broker-initiated disconnections immediately rather than only through keep-alive pings.
Key Changes:
- Added EOF check at the beginning of
readFromSocket()method to detect socket closure in both blocking and non-blocking modes - Throws
DataTransferExceptionwith appropriate error message when EOF is detected
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we only check for EOF when reading in blocking mode. The client uses non-blocking reads most of the time though, such that we need to also check for EOF in those cases.
This fix is in direct response to php-mqtt/laravel-client#73 which shows that a disconnect is currently only detected through the keep alive pings and not by reading from the socket.