Add note about SORT_REGULAR + numeric strings bug to array_unique() #4958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <note> | ||
| <simpara> | ||
| Be careful when using this flag in combination with numeric strings | ||
| as array values since this causes them to not be filtered out |
There was a problem hiding this comment.
Maybe you can be more precise. "Can result in duplicate values"
There was a problem hiding this comment.
Yeah, I wasn't sure how to word it to not make the text too long 😅
There was a problem hiding this comment.
Using this flag can result in duplicate values like: [5, 10, '3A', 5]
There was a problem hiding this comment.
Ah, okay—I'd leave that to the maintainers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in php/php-src#20262 (comment) by @marius-ciclistu